fix: use prefered name in FAP panels - #1266
Merged
Merged
Conversation
bolmsten
approved these changes
Nov 18, 2025
bolmsten
reviewed
Nov 18, 2025
| > | ||
| <TableCell component="th" scope="row"> | ||
| {row.firstname} | ||
| {row.preferredname ? row.preferredname : row.firstname} |
Contributor
There was a problem hiding this comment.
I am wondering if we should always set the preferredname, so we do not need to do these checks everywhere. If a user has a preferredname we set it otherwise we set preferredame using name.
Contributor
Author
There was a problem hiding this comment.
I've open a issue to do a larger code wide change: UserOfficeProject/issue-tracker#1499
TCMeldrum
marked this pull request as ready for review
November 21, 2025 10:46
github-actions
Bot
force-pushed
the
1496-update-panel-memebers-to-prefered-name
branch
from
November 21, 2025 10:47
26970e8 to
8ed5006
Compare
github-actions
Bot
force-pushed
the
1496-update-panel-memebers-to-prefered-name
branch
from
November 25, 2025 16:22
8ed5006 to
3ab0c33
Compare
ACLay
approved these changes
Dec 2, 2025
TCMeldrum
enabled auto-merge (squash)
December 2, 2025 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: UserOfficeProject/issue-tracker#1496
Description
This PR introduces changes to use the preferred name of a user in FAP panels instead of the first name.
Motivation and Context
The change is required to enhance the user experience by addressing and referring to the users by their preferred name. It resolves the issue of misaddressing users who prefer to be known by names other than their first names.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?